Skip to content

Fix Azure DevOps checkout step in the courtesy-push.js file #21204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 11, 2025

Conversation

surajitshil-03
Copy link
Contributor

Context

Fix the issue in the previous PR: #21200
Failed pipeline run link: https://dev.azure.com/mseng/AzureDevOps/_build/results?buildId=30323883&view=logs&s=7cadbae7-7533-548a-becd-a2da10fc0146


Task Name

NA


Description

Key changes include:

  • Removed AzureDevOps repository from pipeline resources to prevent CG dependency conflicts
  • Implemented repository checkout logic within courtesy-push.js
  • Added a dryRun parameter to avoid pushing of nuget artifacts into the feed and also avoid PR creation
  • The display name of the publish job is changed to 'Publish Nuget Artifacts'
  • Added access token to clone the AzureDevOps repo

Risk Assessment (Low / Medium / High)

Low


Change Behind Feature Flag (Yes / No)

No because this is a release pipeline.


Tech Design / Approach

The original pipeline approach included AzureDevOps repository as a pipeline resource, which created CG dependency conflicts. Additionally, there was no safe testing mechanism for validating the entire workflow without external side effects.

Changes made:

  • Eliminated the AzureDevops repository resource from azure-pipelines.yml and implemented the checkout logic within courtesy-push.js
  • Added a dryRun parameter which allows to run all the steps but skips actual pushing of Nuget artifacts to the feed and also skips pushing release notes created in the azure-pipelines-tasks repo. This also skips creation of PR for the changes made in the unified_deps.xml file

Documentation Changes Required (Yes/No)

Yes.
Added a new paramter dryRun in the courtesy push pipeline.

Image:
image


Unit Tests Added or Updated (Yes / No)

No - This is an internal refactor of existing functionality. The courtesy push logic remains functionally equivalent, and comprehensive testing will be performed through integration testing in the pipeline environment


Additional Testing Performed

Locally tested:

  • Verified repository cloning logic with various environment variable configurations.
  • Validated temp directory path resolution in Azure DevOps agent environment
  • Confirmed dryRun parameter correctly skips actual PR creation steps

Logging Added/Updated (Yes/No)

Yes


Telemetry Added/Updated (Yes/No)

No


Rollback Scenario and Process (Yes/No)

NA


Dependency Impact Assessed and Regression Tested (Yes/No)

NA


Checklist

NA

@surajitshil-03 surajitshil-03 requested review from tarunramsinghani and a team as code owners August 8, 2025 07:58
@surajitshil-03
Copy link
Contributor Author

/azp run

@surajitshil-03
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@surajitshil-03
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@surajitshil-03
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@surajitshil-03
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@surajitshil-03 surajitshil-03 merged commit 353110d into master Aug 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants